-
Notifications
You must be signed in to change notification settings - Fork 505
Conversation
This seems to block PermissionScope.show() at |
I've updated this to ask for bluetooth permissions without calling start/stop advertising, and without blocking the main thread. The iOS Bluetooth permission dialog seems to trigger only once per bundle ID; restarting/reinstalling the app doesn't trigger it again. |
@felix-dumit This commit (from issue #107) replaces the call to start/stop advertising with just creation of the bluetooth manager. This seems to request the permission just fine for me but I recall something about this in your original commit for bluetooth support. Was there some situation that required the start/stop calls? |
So I tested and it did work, but I could swear before by just instantiating the manager the system permission would not show up. So probably the best solution to fix #107 is to check in |
Thanks for the feedback @felix-dumit, I'll check this out in the objc example. We do have some plans to behave differently for async permissions requests, such as cloudkit. Maybe best to wrap the removal of |
Sounds good. I was thinking maybe it would make sense to wrap the results of the status callbacks using a promise or future. |
Addresses #106, but maybe having a configurable flag that defaults to true is better instead
Addresses #107