Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add argument to specify a "source" as an alternative to the ember-data store #87

Merged

Conversation

joegaudet
Copy link

This commit adds an optional source argument, this allows a user to
replace the store with a model as the source for querying related
records. Useful when using ember-data-has-many-query.

This commit adds an optional source argument, this allows a user to
replace the store with a model as the source for querying related
records. Useful when using ember-data-has-many-query.
@nickschot
Copy link
Owner

This would solve #86 right?

@joegaudet
Copy link
Author

@nickschot yep!

this.store.query...

When using ember-data-has-many-query

is equivalent to

this.source.query...

@joegaudet
Copy link
Author

Any chance we can get this into a release?

@nickschot nickschot changed the title Add source argument Add argument to specify a "source" as an alternative to the ember-data store Jul 16, 2020
@nickschot nickschot added the enhancement New feature or request label Jul 16, 2020
@nickschot nickschot merged commit b2273dc into nickschot:master Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants