Remove calls to logrus.Fatal() and panic() in library components #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h logging and returning errors. Controller.WaitForReady() now returns an error if one occurs during ListenAndServe().
|
Lgtm! Thanks @dismantl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use the ligolo-ng library packages in my own application, and noticed when attempting to listen on a port that was already in use, instead of returning an error the whole program would exit due to a call to
logrus.Fatal. According to Go best practices, libraries should avoid exposing panics and prefer to log/return errors when possible (and I would say this extends to functions like logrus.Fatal), so that's what this PR attempts to do. It also adds a check to make sure port 80 is available before starting a web server for Let's Encrypt cert generation.Thanks for all your work on ligolo-ng, it is a fantastic tool!