Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From Mephisto to WizardsWardrobe #21

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Drlanderf
Copy link

Hi, complete list of what's going on :

  • Changing version to v2.0.0 (It's a major update adding DG)
  • Adding Missing food
  • Change the folder architecture
  • Add all DG DLC
  • Change zone for loke and yolna on SS (due to auto-equip issue, with new coord, work better)
  • Update the version API used for (Better in the inteface to don't see "out of date")
  • Change in english the "lock movement" into "lock ui" (Users prefer this word)
  • Add my IDE env variable to gitignore

Still todo list :

  • Translate for every DLC DG
  • Found node.id for each DLC DG, and missing arenas (to enable teleport inside all DG and all arenas)
  • Need more test on DLC DG for the auto-equip
  • Following recommendations, it would perhaps be vital to change the interface, in fact, the dungeons being numerous it is a bit embroidered, therefore I would suggest making subcategories at the drop-down menu and/or being able to allow you to enable/disable DLC dungeons via the addon settings menu (requires a reloadui)
    image

@Drlanderf
Copy link
Author

Also, there is an issue about ROM (ruin of Mazzatun), the icon i put don't display.

@JNSlevin
Copy link
Collaborator

JNSlevin commented Apr 2, 2024

Thank you for the PR!

Currently im testing the next version from WW so all of this will have to wait until im confident that works.

I did already plan on adding the dungeons, it is on my to do list but fixing some issues have a higher priority for now.

Once im confident all of those new changes are working correctly ill review your changes! Thank you!

@Drlanderf
Copy link
Author

I will try to check how currently get the id.nodes for teleportation, if u have an idea i will take him, normaly every DLC dg work fine for now, if u need help to test something or anything else tell me i'm open

@DakJaniels
Copy link

I will try to check how currently get the id.nodes for teleportation, if u have an idea i will take him, normaly every DLC dg work fine for now, if u need help to test something or anything else tell me i'm open

In LibSets from Baertram, there is a spreadsheet with all the data id’s you could possibly use.

@Drlanderf Drlanderf marked this pull request as draft April 2, 2024 13:40
@Drlanderf
Copy link
Author

I will try to check how currently get the id.nodes for teleportation, if u have an idea i will take him, normaly every DLC dg work fine for now, if u need help to test something or anything else tell me i'm open

In LibSets from Baertram, there is a spreadsheet with all the data id’s you could possibly use.

thanks, i fix it adding node for every DG/arenas, still missing for 2 new DLC DG, not found in lib spreadsheet

  • Bedlam Veil (BV)
  • Oathsworn Pit (OP)

@Drlanderf Drlanderf marked this pull request as ready for review April 2, 2024 13:44
@Baertram
Copy link

Baertram commented Apr 2, 2024

If you refer to the wayshrine node IDs: Those are in the actual LibSets_SetData.xlsm file
https://github.com/Baertram/LibSets/tree/LibSets-reworked/LibSets/Data

Map/tab "ESO wayshrine names"
Filter the "Name EN" for "Dungeon: *" and you will see the list

565 | Dungeon: Bedlam Veil
556 | Dungeon: Oathsworn Pit

@Drlanderf
Copy link
Author

Drlanderf commented Apr 2, 2024

If you refer to the wayshrine node IDs: Those are in the actual LibSets_SetData.xlsm file https://github.com/Baertram/LibSets/tree/LibSets-reworked/LibSets/Data

Map/tab "ESO wayshrine names" Filter the "Name EN" for "Dungeon: *" and you will see the list

565 | Dungeon: Bedlam Veil 556 | Dungeon: Oathsworn Pit

ho ok, because i was download on eso ui, i will make in fav the github so i was looking in the wrong tab

@Baertram
Copy link

Baertram commented Apr 2, 2024

The esoui uploaded addon .zip contains the same excel file, so it should not matter which to use.
Github maybe even older sometimes as I do not update it at the same time ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants