Skip to content

Commit

Permalink
[qt] Add patches to fix missing includes
Browse files Browse the repository at this point in the history
This is needed to build with GCC11

Fixes microsoft#19226
  • Loading branch information
nicolasfella committed Aug 20, 2021
1 parent ab60f27 commit f84e235
Show file tree
Hide file tree
Showing 7 changed files with 84 additions and 3 deletions.
51 changes: 51 additions & 0 deletions ports/qt5-base/patches/limits_include.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
From 61325e4547225b8b2ecefda4ca328a38c075c909 Mon Sep 17 00:00:00 2001
From: Nicolas Fella <nicolas.fella@gmx.de>
Date: Wed, 11 Aug 2021 15:35:05 +0200
Subject: [PATCH] Add missing limits include

---
src/corelib/global/qendian.h | 1 +
src/corelib/global/qfloat16.h | 1 +
src/corelib/text/qbytearraymatcher.h | 2 ++
3 files changed, 4 insertions(+)

diff --git a/src/corelib/global/qendian.h b/src/corelib/global/qendian.h
index 257efbbdbe..05f11d6f81 100644
--- a/src/corelib/global/qendian.h
+++ b/src/corelib/global/qendian.h
@@ -47,6 +47,7 @@
// include stdlib.h and hope that it defines __GLIBC__ for glibc-based systems
#include <stdlib.h>
#include <string.h>
+#include <limits>

#ifdef min // MSVC
#undef min
diff --git a/src/corelib/global/qfloat16.h b/src/corelib/global/qfloat16.h
index c7a9c87af3..3287d7cbf2 100644
--- a/src/corelib/global/qfloat16.h
+++ b/src/corelib/global/qfloat16.h
@@ -44,6 +44,7 @@
#include <QtCore/qglobal.h>
#include <QtCore/qmetatype.h>
#include <string.h>
+#include <limits>

#if defined(QT_COMPILER_SUPPORTS_F16C) && defined(__AVX2__) && !defined(__F16C__)
// All processors that support AVX2 do support F16C too. That doesn't mean
diff --git a/src/corelib/text/qbytearraymatcher.h b/src/corelib/text/qbytearraymatcher.h
index 0eedfc1d20..f5f9bef7b8 100644
--- a/src/corelib/text/qbytearraymatcher.h
+++ b/src/corelib/text/qbytearraymatcher.h
@@ -42,6 +42,8 @@

#include <QtCore/qbytearray.h>

+#include <limits>
+
QT_BEGIN_NAMESPACE


--
2.32.0

1 change: 1 addition & 0 deletions ports/qt5-base/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ qt_download_submodule( OUT_SOURCE_PATH SOURCE_PATH
#CMake fixes
${PATCHES}
patches/Qt5GuiConfigExtras.patch # Patches the library search behavior for EGL since angle is not build with Qt
patches/limits_include.patch # Add missing includes to build with gcc 11
)

# Remove vendored dependencies to ensure they are not picked up by the build
Expand Down
2 changes: 1 addition & 1 deletion ports/qt5-base/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "qt5-base",
"version-semver": "5.15.2",
"port-version": 9,
"port-version": 10,
"description": "Qt5 Application Framework Base Module. Includes Core, GUI, Widgets, Networking, SQL, Concurrent and other essential qt components.",
"homepage": "https://www.qt.io/",
"dependencies": [
Expand Down
24 changes: 24 additions & 0 deletions ports/qt5-declarative/limits_include.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
From 2dfb893c130a9f9195805fcc81d7e5e242bc558d Mon Sep 17 00:00:00 2001
From: Nicolas Fella <nicolas.fella@gmx.de>
Date: Wed, 11 Aug 2021 17:03:06 +0200
Subject: [PATCH] Add missing limits include

---
src/qmldebug/qqmlprofilerevent_p.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/src/qmldebug/qqmlprofilerevent_p.h b/src/qmldebug/qqmlprofilerevent_p.h
index a7e37d1964..01b2f58f16 100644
--- a/src/qmldebug/qqmlprofilerevent_p.h
+++ b/src/qmldebug/qqmlprofilerevent_p.h
@@ -48,6 +48,7 @@
#include <QtCore/qmetatype.h>

#include <initializer_list>
+#include <limits>
#include <type_traits>

//
--
2.32.0

2 changes: 1 addition & 1 deletion ports/qt5-declarative/portfile.cmake
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
include(${CURRENT_INSTALLED_DIR}/share/qt5/qt_port_functions.cmake)
qt_submodule_installation()
qt_submodule_installation(PATCHES limits_include.patch)
2 changes: 1 addition & 1 deletion versions/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -5194,7 +5194,7 @@
},
"qt5-base": {
"baseline": "5.15.2",
"port-version": 9
"port-version": 10
},
"qt5-canvas3d": {
"baseline": "0",
Expand Down
5 changes: 5 additions & 0 deletions versions/q-/qt5-base.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "2824837f3a0c083c90bf8fe0e564df3cefcb110f",
"version-semver": "5.15.2",
"port-version": 10
},
{
"git-tree": "2362119eaacd46f6d1b0d27bac82b8851d84448f",
"version-semver": "5.15.2",
Expand Down

0 comments on commit f84e235

Please sign in to comment.