Error locations are already converted from URLs to paths by Jest #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
reviewed
Aug 24, 2022
| snapshotState._inlineSnapshots.forEach(({ frame }) => { | ||
| // When using native ESM, errors have a URL location. | ||
| // Jest expects paths. | ||
| frame.file = fileURLToPath(frame.file); |
There was a problem hiding this comment.
If by any chance frame.file could be a URL, we can test if frame.file starts with file:// and then apply the transform.
There was a problem hiding this comment.
It was probably for an older Jest 27 version, we can just bump the peer dep requirement.
There was a problem hiding this comment.
jestjs/jest#12277, so 27.5 can be minimum if you don't wanna leave 27 behind 🙂
Not sure , didn't notice that. |
|
Looks like this is the only one https://github.com/prettier/prettier/blob/f33ae9f5833f453114338ceb9f263fcf13f122b9/tests/integration/__tests__/format.js#L60 |
|
When I was debugging |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes babel/babel#14867 (comment)
@fisker Do you use inline snapshots in Prettier, and if yes did you ever had problems with the
-uJest options not working?