Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix snapshot test #60

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Fix snapshot test #60

merged 1 commit into from
Oct 28, 2022

Conversation

fisker
Copy link
Contributor

@fisker fisker commented Oct 27, 2022 •
edited
Loading

  • Correct status report
  • Correctly remove outdated snapshot

Fixes #48

@fisker fisker changed the title Fix snapshot state Fix snapshot test Oct 27, 2022
@fisker fisker marked this pull request as ready for review October 27, 2022 03:25
@fisker
Copy link
Contributor Author

fisker commented Oct 27, 2022

Prettier already have obsolete snapshot committed https://github.com/nicolo-ribaudo/jest-light-runner/actions/runs/3334238891/jobs/5516991993#step:8:1165

@fisker
Copy link
Contributor Author

fisker commented Oct 28, 2022

@nicolo-ribaudo

@nicolo-ribaudo
Copy link
Owner

Thank you! It's ironic that the proof that this PR is correct is that the CI fails :)

@nicolo-ribaudo nicolo-ribaudo merged commit 8d41c1f into nicolo-ribaudo:main Oct 28, 2022
@fisker fisker deleted the snapshot-state branch October 28, 2022 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not updating snapshot correctly
2 participants
@fisker @nicolo-ribaudo