Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse CI enhancement #23

Merged
merged 7 commits into from
Jun 11, 2024
Merged

Lighthouse CI enhancement #23

merged 7 commits into from
Jun 11, 2024

Conversation

nonumpa
Copy link
Contributor

@nonumpa nonumpa commented May 28, 2024

Changes

  • 整合 lighthouse github app 顯示結果
  • 修正 lighthouse 只檢查 production 的問題
    • 使用 "startServerCommand": "bundle exec jekyll server"
    • 改用 localhost 的 url
    • 因為 assets 使用絕對路徑,所以不能 build 完後使用 collect.staticDistDir 這個方法,random port
  • 修正 lighthouse 只檢查首頁的問題
    • url 加入其他頁面
  • 修正 action node 版本過時的問題

TODOs

  • 開發新頁面要可以不用另外設定就可以掃描到
    • 目前要另外在 lhci.yml 手動加入 url
  • 減少 action 執行時間
    • 目前一次檢查太多 url,action 執行時間有點長

@nonumpa
Copy link
Contributor Author

nonumpa commented May 28, 2024

不知道哪裡設定錯了,一直 GitHub token not set
截圖 2024-05-28 上午9 55 18

@nonumpa
Copy link
Contributor Author

nonumpa commented May 28, 2024

設定成 environment secrets 了,改成 repository secrets 就好了
secret

@nonumpa nonumpa merged commit cb3cdc5 into main Jun 11, 2024
3 checks passed
@nonumpa nonumpa deleted the feature/lhci branch June 17, 2024 03:00
nonumpa added a commit that referenced this pull request Jun 29, 2024
the commit is #855a536
fix: [lang] attributes do not have a valid value by updating vn to vi
nonumpa added a commit that referenced this pull request Jun 29, 2024
the commit is #855a536
fix: [lang] attributes do not have a valid value by updating vn to vi
nonumpa added a commit that referenced this pull request Jun 29, 2024
fix: maturity function that was accidentally broke in pr #23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant