Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add component datalist #27

Merged
merged 4 commits into from
Jan 17, 2025
Merged

feat: add component datalist #27

merged 4 commits into from
Jan 17, 2025

Conversation

nonumpa
Copy link
Contributor

@nonumpa nonumpa commented May 31, 2024 •
edited
Loading

#15

問題

  • 親和力問題
    • options list 只有在 input 還是空白的時候會跳出來，當已經選擇的時候（input 有值的時候），就只會顯示已過濾的選項
    • <option> 不支援高對比模式
    • <option> 字體大小無法放大縮小
    • datalist 的 <option> popup，都是各瀏覽器自己定義的樣式，開發者不能直接用 css 修改，會有使用者看到的樣式在不同裝置顯示不太一樣的問題，看到的其他人的做法都是不使用 datalist 預設的功能，使用 js 另外去監聽 event，但這樣好像就失去使用 datalist 的意義了
  • 支援率問題

結論

目前 datalist 比較像是半成品，未來可能會用 JS 實作比較完整的可搜尋選項列表，把 datalist 做為沒有啟用 JS 的 fallback 機制

其他參考

@nonumpa nonumpa temporarily deployed to github-pages May 31, 2024 06:05 — with GitHub Pages Inactive
@nonumpa nonumpa force-pushed the feature/datalist branch from 60e5efa to 06ba495 Compare May 31, 2024 06:09
@nonumpa nonumpa temporarily deployed to github-pages May 31, 2024 06:10 — with GitHub Pages Inactive
@nonumpa nonumpa force-pushed the feature/datalist branch from 06ba495 to 8a81b76 Compare May 31, 2024 06:26
@nonumpa nonumpa temporarily deployed to github-pages May 31, 2024 06:26 — with GitHub Pages Inactive
@nonumpa nonumpa temporarily deployed to github-pages May 31, 2024 08:19 — with GitHub Pages Inactive
@nonumpa nonumpa force-pushed the feature/datalist branch from b4bc36a to 932a4fd Compare June 7, 2024 02:51
@nonumpa nonumpa temporarily deployed to github-pages June 7, 2024 02:52 — with GitHub Pages Inactive
@nonumpa nonumpa force-pushed the feature/breadcrumb branch from 96b836d to 169765f Compare June 19, 2024 02:21
Base automatically changed from feature/breadcrumb to main June 19, 2024 02:28
@nonumpa nonumpa force-pushed the feature/datalist branch 2 times, most recently from 3a7f92c to d697270 Compare June 24, 2024 03:03
@nonumpa nonumpa temporarily deployed to github-pages June 24, 2024 03:24 — with GitHub Pages Inactive
@nonumpa nonumpa force-pushed the feature/datalist branch from d697270 to a724a7d Compare June 24, 2024 03:50
@nonumpa nonumpa temporarily deployed to github-pages June 24, 2024 03:51 — with GitHub Pages Inactive
@nonumpa nonumpa force-pushed the feature/datalist branch 3 times, most recently from 7079004 to 4cfdd2b Compare January 16, 2025 10:11
@nonumpa nonumpa added the ci-lighthouse trigger lighthouse check label Jan 16, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 16, 2025 •
edited
Loading

Deployed to https://storage.googleapis.com/guide-dev/12806846711/index.html

@nonumpa nonumpa added ci-lighthouse trigger lighthouse check and removed ci-lighthouse trigger lighthouse check labels Jan 16, 2025
@nonumpa nonumpa marked this pull request as ready for review January 16, 2025 10:30
@nonumpa nonumpa requested a review from a team January 16, 2025 10:30
@nonumpa nonumpa merged commit 831a5a9 into main Jan 17, 2025
34 checks passed
@nonumpa nonumpa deleted the feature/datalist branch January 22, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci-lighthouse trigger lighthouse check
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nonumpa