Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a11y issues #40

Merged
merged 3 commits into from
Aug 23, 2024
Merged

fix: a11y issues #40

merged 3 commits into from
Aug 23, 2024

Conversation

IK-Ngoo
Copy link
Contributor

@IK-Ngoo IK-Ngoo commented Aug 17, 2024 •
edited
Loading

修正偏向 html 語法問題。

  • fix(components): set unique id for maturity detail by adding postfix
    影響全部元件，各項成熟度的細節說明，設定了重複的 id。
  • fix(form): set valid value for autocomplete attr
    影響表單元件，自動完成全名，autocomplete 應設定為 name。
  • fix(skip-to): set font-size using relative unit
    影響 skip-to 元件，字體大小改為相對尺度單位。

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 22, 2024 •
edited
Loading

Deployed to https://storage.googleapis.com/guide-dev/10519084615/index.html

@nonumpa nonumpa self-requested a review August 23, 2024 09:08
nonumpa
nonumpa approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@nonumpa nonumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nonumpa nonumpa merged commit 54564c3 into nics-tw:main Aug 23, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonumpa nonumpa nonumpa approved these changes

Assignees
No one assigned
Labels
safe-to-deploy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IK-Ngoo @nonumpa