-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20240318, Reporter User Guide and Reporter debug #369
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheme-justyn
added
the
documentation
Improvements or additions to documentation
label
Mar 18, 2024
matheme-justyn
added this to the 20240328, Feasibility study - Downstream task milestone
Mar 18, 2024
matheme-justyn
changed the title
20240318, Reporter User Guide
20240318, Reporter User Guide and Reporter debug
Mar 19, 2024
Syn 347 to expt
matheme-justyn
force-pushed
the
347-readme-reporter
branch
from
March 24, 2024 14:24
0ce55d5
to
51c667d
Compare
matheme-justyn
force-pushed
the
347-readme-reporter
branch
from
March 24, 2024 15:31
7afccf2
to
20f0851
Compare
matheme-justyn
force-pushed
the
347-readme-reporter
branch
from
March 25, 2024 01:59
e4b8641
to
5079fc8
Compare
matheme-justyn
force-pushed
the
347-readme-reporter
branch
from
March 25, 2024 02:01
5079fc8
to
750e020
Compare
ghost
suggested changes
Mar 25, 2024
ghost
approved these changes
Mar 26, 2024
ghost
deleted the
347-readme-reporter
branch
March 26, 2024 06:06
ghost
mentioned this pull request
Mar 26, 2024
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #347
(這個 branch 是 #367 的分岔,請先審 #367
這次除了寫 Reporter 的 README,在寫範例的過程中遇到的問題,也因此對
PETsARD
做出兩個改動:Reporter
save_report 的輸出格式會同時個別紀錄每個模組的實驗名稱full_expt_name
紀錄該評分所使用的所有模組所有實驗名稱,蠻不好使用。full_expt_name
是 'Loader[adult-income]Evaluator[default[global]]' 跟 Loader[bank-marketing-2]Evaluator[default[global]]Loader
值是 'adult-income' 跟 'bank-marketing-2',另一列則是Evaluator
值都是 'default_[global]'將
Reporter
save_report 方法沒辦法順利的累積報告的現況修復:Loader
、一個Evaluator
,針對Evaluator
做Reporter
,輸出卻發現只有最後一個Loader
的Evaluator
一行資料reporter.create(data=data)
傳入的data['exist_report']
未發揮作用Executor
中應該在Status.put()
裡面被Status.set_report(report=report)
儲存到Status.report
這個 dict 裡,但在ReporterOperator.get_result()
傳出來的格式不如預期,導致過去的 report 都沒被Status
存下來這兩點都不動到模組設計,算是 debug,故希望 @alexchen830 直接審批即可,thanks
Improvement
ReporterOperator.run()
的判斷條件 - cae7dacEvaluator
,Reporter.report_data
簡化名稱為Reporter.result
- 303bcc2.create(data)
的檢核簡化,並統一在ReporterBase._verify_create_input(data)
方法裡執行 - 5a2c472 927d9e0ReporterBase.get_full_expt_name(full_expt_tuple)
,統一管理 full_expt_name 的邏輯 - 2731b7dReporterSaveReport._process_report_data()
以此簡化報表產製邏輯 - 65c74edEvaluator
,Reporter.report_data
簡化名稱為Reporter.result
- 303bcc2Fixation
Status
在.put()
的判斷 - 68c1bacReporter
就直接整個ReporterOperator.get_result()
的結果進Status.set_report()
Status.set_report()
中做 reportpd.concat()
,讓Reporter
簡化為只需要考慮該次報告即可,導致了報告會重複疊加。僅保留
Reporter.create()的報告疊加,移除
Status.set_report()` 的報告疊加 - bfc6f38ReporterSaveReport.create()
的中繼檔 rpt_data 不需要 deepcopy - af8ea0d__init__
docstring: eval 應該是實驗名稱(自訂的),不是實驗用的方式(method in Evaluator) - 111d819ReporterSaveData.create()
comment typo - c3cfb86Reporter.result
應該在Reporter.report()
才從工廠方法那邊拿來 - 37c812b,導致了報告會重複疊加。僅保留
Reporter.create()的報告疊加,移除
Status.set_report()` 的報告疊加 - bfc6f38Future
Sunset