-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
20240327, Reporter support no need eval #401
Merged
matheme-justyn
merged 19 commits into
dev
from
395-reporter-save_report-only-needs-granularity
Mar 27, 2024
Merged
20240327, Reporter support no need eval #401
matheme-justyn
merged 19 commits into
dev
from
395-reporter-save_report-only-needs-granularity
Mar 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync dev to #395
matheme-justyn
changed the title
20240326, Reporter support no need eval
20240327, Reporter support no need eval
Mar 26, 2024
…ps://github.com/nics-tw/PETsARD into 395-reporter-save_report-only-needs-granularity
matheme-justyn
added
bug
Something isn't working
enhancement
New feature or request
labels
Mar 27, 2024
matheme-justyn
added this to the 20240328, Feasibility study - Downstream task milestone
Mar 27, 2024
衝突審批完再解,#400 就是我試圖解衝突導致的提前合併 |
ghost
approved these changes
Mar 27, 2024
matheme-justyn
deleted the
395-reporter-save_report-only-needs-granularity
branch
March 27, 2024 09:20
matheme-justyn
restored the
395-reporter-save_report-only-needs-granularity
branch
March 28, 2024 01:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原本的 20240326, Reporter support no need eval #396 在試圖解決衝突的 Sync dev to #395 #400 中錯誤合併,請先通過 revert 的 20240326, Reporter support no need eval #396 再回來通過這支
經測試在這個改動後,@alexchen830 遇到的報告錯誤覆蓋問題可望解決。本機測試參考如下
Fixation
eval
成為可選項,如果沒設定預設為 None - 8bd35eeReporterSaveReport
當中,當eval
為 None 時、任何一個以f"_[{granularity}]"
結尾都會被抓到,而當eval
為任意長度的List[str]
,便需要完整配對f"{eval}_[{granularity}]"
- 885a73eReporter.report_data['Reporter']
將不再有'full_expt_name'
(已以報告中一欄的形式儲存) 與'expt_name'
(現在接受多個eval
的結果),取而代之的是,原本'eval_name'
只有配對到的eval_expt_name
本身,現在放開定義如下: - 68eea93eval
未給定,為 f"[{granularity}]",eval
給定,則為 f"{eval}_[{granularity}],多個
eval間用 dash
-` 連結ReporterSaveReport_safe_merge()
- 312ddfa d917a95full_expt_name
跟Evaluator
/Describer
部分簡化,使其不要因不同的評量方法而成為不同行,只要是同一個細粒度 (or + 給定的eval
搜尋) 就會左側參考欄位同樣的值,使其可以合併為同一行 - f70985bImprovement
ReporterSaveReport
的granularity
加上型別須為str
的檢查 - ad54420 8aaf13fReporterBase.SAVE_REPORT_AVAILABLE_MODULE
簡化邏輯 - 98e7132convert_full_expt_tuple_to_name()
簡化邏輯維護 - 026fd8fconvert_full_expt_tuple_to_name()
簡化邏輯維護 - 026fd8fconvert_full_expt_name_to_tuple()
簡化邏輯維護 - aaa3e97convert_eval_expt_name_to_tuple()
簡化邏輯維護 - af165e8full_expt_tuple_filter()
簡化邏輯維護 - c6ae00aTesting
test_method
- ab7cb86test_method_save_data
- ce60bd7 ad54420test_method_save_report
- ce60bd7 ad54420test_source
- 7adbf1b ad54420test_granularity
- ad54420test_eval
- 275afc8test_create
- a56f63a e12edd5test_process_report_data
- 396247etest_safe_merge
- 77c82dftest_convert_full_expt_tuple_to_name
- aaa3e97test_convert_full_expt_name_to_tuple
- aaa3e97test_convert_eval_expt_name_to_tuple
- 396247efull_expt_name
跟Evaluator
/Describer
部分簡化」而導致的測試更動問題 - e44f9caDocumentation
Reporter
和Reporter.create()
- c8109a8