Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20240327, Reporter support no need eval #401

Merged
merged 19 commits into from
Mar 27, 2024

Conversation

matheme-justyn
Copy link
Contributor

@matheme-justyn matheme-justyn commented Mar 26, 2024

image

  • Fixation

    • PETsARD\reporter\reporter.py
      • 讓 method = 'save_report' 時的 eval 成為可選項,如果沒設定預設為 None - 8bd35ee
      • ReporterSaveReport 當中,當 eval 為 None 時、任何一個以 f"_[{granularity}]" 結尾都會被抓到,而當 eval 為任意長度的 List[str],便需要完整配對 f"{eval}_[{granularity}]" - 885a73e
      • 即使評測結果不存在 (e.g. Evaluator/Describer 沒有所指定的顆粒度),僅彈訊息告知而不會停止搜尋 - efe8acc
      • 即使評測結果存在、完成報告紀錄,也不會提早結束,使「不只抓特定的 eval + granularity」成為可能 - a426ddc
      • 由於改動,Reporter.report_data['Reporter'] 將不再有 'full_expt_name' (已以報告中一欄的形式儲存) 與 'expt_name' (現在接受多個 eval 的結果),取而代之的是,原本 'eval_name' 只有配對到的 eval_expt_name 本身,現在放開定義如下: - 68eea93
        • 如果 eval 未給定,為 f"[{granularity}]",
        • eval 給定,則為 f"{eval}_[{granularity}],多個 eval間用 dash-` 連結
        • 修正 docstring - 8ed8047
      • 依此完成開發 ReporterSaveReport_safe_merge() - 312ddfa d917a95
      • 並進一步讓產生報告的左側參考欄位中,將 full_expt_nameEvaluator/Describer 部分簡化,使其不要因不同的評量方法而成為不同行,只要是同一個細粒度 (or + 給定的 eval 搜尋) 就會左側參考欄位同樣的值,使其可以合併為同一行 - f70985b
      • 修正 README - Reporter #347 帶來的版本衝突 - 7d06671
  • Improvement

    • PETsARD\reporter\reporter.py
      • ReporterSaveReportgranularity 加上型別須為 str 的檢查 - ad54420 8aaf13f
      • 使用 ReporterBase.SAVE_REPORT_AVAILABLE_MODULE 簡化邏輯 - 98e7132
      • 導入 convert_full_expt_tuple_to_name() 簡化邏輯維護 - 026fd8f
    • PETsARD\reporter\utils.py
      • 導入 convert_full_expt_tuple_to_name() 簡化邏輯維護 - 026fd8f
      • 導入 convert_full_expt_name_to_tuple() 簡化邏輯維護 - aaa3e97
      • 導入 convert_eval_expt_name_to_tuple() 簡化邏輯維護 - af165e8
      • 導入 full_expt_tuple_filter() 簡化邏輯維護 - c6ae00a
      • 修正 README - Reporter #347 帶來的版本衝突 - 7d06671 5894069
  • Testing

    • tests\reporter\test_reporter.py
      • create and add Test_Reporter::test_method - ab7cb86
      • Test_Reporter::test_method_save_data - ce60bd7 ad54420
      • Test_Reporter::test_method_save_report - ce60bd7 ad54420
      • Test_ReporterSaveData::test_source - 7adbf1b ad54420
      • Test_ReporterSaveReport:: test_granularity - ad54420
      • Test_ReporterSaveReport:: test_eval - 275afc8
      • Test_ReporterSaveReport:: test_create - a56f63a e12edd5
      • Test_ReporterSaveData:: test_process_report_data - 396247e
      • Test_ReporterSaveData:: test_safe_merge - 77c82df
      • Test_utils:: test_convert_full_expt_tuple_to_name - aaa3e97
      • Test_utils:: test_convert_full_expt_name_to_tuple - aaa3e97
      • Test_utils:: test_convert_eval_expt_name_to_tuple - 396247e
      • 修正因「full_expt_nameEvaluator/Describer 部分簡化」而導致的測試更動問題 - e44f9ca
      • 修正 README - Reporter #347 帶來的版本衝突 - 7d06671
  • Documentation

    • docs\posts\2024-02-11-Reporter.md

@matheme-justyn matheme-justyn changed the title 20240326, Reporter support no need eval 20240327, Reporter support no need eval Mar 26, 2024
@matheme-justyn matheme-justyn requested review from mileschangmoda and a user March 27, 2024 02:17
@matheme-justyn matheme-justyn self-assigned this Mar 27, 2024
@matheme-justyn matheme-justyn added bug Something isn't working enhancement New feature or request labels Mar 27, 2024
@matheme-justyn matheme-justyn linked an issue Mar 27, 2024 that may be closed by this pull request
@matheme-justyn matheme-justyn marked this pull request as ready for review March 27, 2024 06:59
@matheme-justyn
Copy link
Contributor Author

衝突審批完再解,#400 就是我試圖解衝突導致的提前合併

@matheme-justyn matheme-justyn merged commit e734c42 into dev Mar 27, 2024
@matheme-justyn matheme-justyn deleted the 395-reporter-save_report-only-needs-granularity branch March 27, 2024 09:20
@matheme-justyn matheme-justyn restored the 395-reporter-save_report-only-needs-granularity branch March 28, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reporter - save_report only needs granularity
1 participant