Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: simplification of util #574

Merged
merged 4 commits into from
Nov 8, 2024
Merged

style: simplification of util #574

merged 4 commits into from
Nov 8, 2024

Conversation

matheme-justyn
Copy link
Contributor

@matheme-justyn matheme-justyn commented Nov 8, 2024 •
edited
Loading

Please merge #573 first

  • style: simplification of util
    • aggregated dtype_operations - d426170
    • safe_round change to numeric_operations - e8fe046

@matheme-justyn matheme-justyn added the enhancement New feature or request label Nov 8, 2024
@matheme-justyn matheme-justyn requested a review from a team November 8, 2024 02:57
@matheme-justyn matheme-justyn self-assigned this Nov 8, 2024
@matheme-justyn matheme-justyn linked an issue Nov 8, 2024 that may be closed by this pull request
Simplification of util #520
Closed
@matheme-justyn matheme-justyn marked this pull request as ready for review November 8, 2024 02:57
CharlesChiuGit
CharlesChiuGit approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@matheme-justyn matheme-justyn merged commit 7ae5153 into dev Nov 8, 2024
@matheme-justyn matheme-justyn deleted the 520-simplification-of-util branch November 8, 2024 05:40
@matheme-justyn matheme-justyn mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesChiuGit CharlesChiuGit CharlesChiuGit approved these changes

Assignees

@matheme-justyn matheme-justyn

Labels
enhancement New feature or request
Projects
None yet
Milestone
20241125, deliver to moda
Development

Successfully merging this pull request may close these issues.

Simplification of util
2 participants
@matheme-justyn @CharlesChiuGit