Skip to content

Commit

Permalink
add Typescript support + convert @superset-ui/connection to Typescript (
Browse files Browse the repository at this point in the history
#41)

* [typescript] add build support for typescript

* [typescript] working lint and build

* [typescript] refactor SupersetClient to TS

* [typescript][connection] leverage RequestInit types when relevant

* [typescript][connection] callApi.js => callApi.ts

* [typescript][connection] remaining .js => .ts

* [typescript][connection] add and export src/types.ts, refactor things, convert test to .ts and fix

* [typescript] build:ts only in typescript-containing packages
  • Loading branch information
williaster authored and zhaoyongjie committed Nov 26, 2021
1 parent 4a92a91 commit b3444d8
Show file tree
Hide file tree
Showing 20 changed files with 403 additions and 239 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,5 @@ logs/
node_modules/
package-lock.json
prettier.config.js
tsconfig.json
yarn.lock
16 changes: 9 additions & 7 deletions superset-frontend/temporary_superset_ui/superset-ui/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,17 @@
"private": true,
"scripts": {
"bootstrap": "lerna bootstrap",
"build": "yarn run build:cjs && yarn run build:esm",
"build": "yarn run build:cjs && yarn run build:esm && yarn run build:ts",
"build:cjs": "NODE_ENV=production beemo babel ./src --out-dir lib/ --minify --workspaces=\"@superset-ui/!(demo|generator-superset)\"",
"build:esm": "NODE_ENV=production beemo babel ./src --out-dir esm/ --esm --minify --workspaces=\"@superset-ui/!(demo|generator-superset)\"",
"lint": "beemo create-config prettier && beemo eslint \"./packages/*/{src,test,storybook}/**/*.{js,jsx}\"",
"build:ts": "NODE_ENV=production beemo typescript --workspaces=\"@superset-ui/connection\"",
"lint": "beemo create-config prettier && beemo eslint \"./packages/*/{src,test,storybook}/**/*.{js,jsx,ts,tsx}\"",
"jest": "beemo jest --color --coverage",
"postrelease": "lerna run gh-pages",
"prepare-release": "git checkout master && git pull --rebase origin master && lerna bootstrap && yarn run test",
"prerelease": "yarn run build",
"pretest": "yarn run lint",
"prettier": "beemo prettier \"./packages/*/{src,test,storybook}/**/*.{js,jsx,json,md}\"",
"prettier": "beemo prettier \"./packages/*/{src,test,storybook}/**/*.{js,jsx,ts,tsx,json,md}\"",
"release": "yarn run prepare-release && lerna publish && yarn run postrelease",
"test": "yarn run jest",
"test:watch": "beemo create-config jest && jest --watch"
Expand All @@ -34,7 +35,7 @@
],
"license": "Apache-2.0",
"devDependencies": {
"@data-ui/build-config": "^0.0.28",
"@data-ui/build-config": "^0.0.31",
"husky": "^1.1.2",
"lerna": "^3.2.1",
"lint-staged": "^8.0.4",
Expand All @@ -54,7 +55,8 @@
"NODE_ENV": "test"
}
},
"prettier"
"prettier",
"typescript"
],
"jest": {
"testPathIgnorePatterns": [
Expand All @@ -66,7 +68,7 @@
"displayName": "node",
"rootDir": "<rootDir>/packages/generator-superset",
"testMatch": [
"<rootDir>/test/**/?(*.)+(spec|test).{js,jsx}"
"<rootDir>/test/**/?(*.)+(spec|test).{js,jsx,ts,tsx}"
],
"testEnvironment": "node"
}
Expand All @@ -82,7 +84,7 @@
}
},
"lint-staged": {
"./packages/*/{src,test,storybook}/**/*.{js,jsx,json,md}": [
"./packages/*/{src,test,storybook}/**/*.{js,jsx,ts,tsx,json,md}": [
"yarn run prettier --write",
"git add"
]
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
"rules": {
"prefer-promise-reject-errors": "off"
"prefer-promise-reject-errors": "off",
"lines-between-class-members": ["error", "always", { "exceptAfterSingleLine": true }]
}
}

This file was deleted.

Loading

0 comments on commit b3444d8

Please sign in to comment.