Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid uploading corrupted cache to S3 #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chirgjn
Copy link

@chirgjn chirgjn commented Aug 9, 2024

The generated tar file can be corrupted, which when used as cache will result
in failures. This PR adds a "check" and "retry" for tar file generation.

@chirgjn chirgjn force-pushed the fix-skip-upload-for-corrupted-cache branch from 66f611e to cfe55cd Compare August 9, 2024 17:59
@gencer
Copy link
Collaborator

gencer commented Aug 9, 2024

Hi @chirgjn

Thanks for the PR. It seems docker-compose is no longer available at latest version of GH Actions. I've fixed in master branch. You may rebase it, if you want and then we can fire a test again here.

🤞

@chirgjn chirgjn force-pushed the fix-skip-upload-for-corrupted-cache branch from cfe55cd to 2b77ac4 Compare August 9, 2024 18:30
@chirgjn chirgjn changed the title avoid uploading corrupted cache to S3 Avoid uploading corrupted cache to S3 Aug 9, 2024
@chirgjn
Copy link
Author

chirgjn commented Aug 9, 2024

Hi @gencer,

Thanks for your response. I've rebased the PR, we can trigger a test run if the changes look fine to start testing.

@gencer
Copy link
Collaborator

gencer commented Aug 9, 2024

CI reports failures due to changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants