Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from scikit-build to scikit-build-core #104

Closed
nightlark opened this issue Dec 5, 2023 · 0 comments · Fixed by #126
Closed

Migrate from scikit-build to scikit-build-core #104

nightlark opened this issue Dec 5, 2023 · 0 comments · Fixed by #126
Labels
help wanted Extra attention is needed

Comments

@nightlark
Copy link
Owner

Try migrating from scikit-build to scikit-build-core, which could remove the need for setup.py and MANIFEST.in files.

scikit-build/scikit-build-core#274 (comment) mentions an additional step that is needed for using setuptools_scm for versioning.

One unknown issue (that works with setuptools specifies data/share/swig subfolder in setup.py but not in pyproject.toml) is whether or not those swig support files that get installed will be included in the correct subfolder when building using scikit-build-core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant