Use GHA M1 runners for macOS builds #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightlark
force-pushed
the
gha-m1-runners
branch
6 times, most recently
from
b14c14d to
a8927c3
Compare
nightlark
force-pushed
the
gha-m1-runners
branch
from
a8927c3 to
fcd4a6f
Compare
nightlark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make the macOS builds finish a bit faster, and enable running tests on the arm64 wheel.
pipx is not included with the new macOS images, and some things aren't quite working with the install path for pipx installed tools not being added to the PATH -- the easiest workaround was adding a step to install ninja using brew. There may be a pair of unneeded cmake and ninja versions installed, but the system installed copies work just as well. Migrating to scikit-build-core eventually (#104) should make the cibuildwheel
before-allsection unnecessary and at least partially clean things up...