Barcode support #74 #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed receiver leak Moar tests
| @@ -241,6 +240,7 @@ protected void onDestroy() { | |||
| super.onDestroy(); | |||
| unregisterReceiver(mCGMStatusReceiver); | |||
| unregisterReceiver(mDeviceStatusReceiver); | |||
| unregisterReceiver(toastReceiver); | |||
There was a problem hiding this comment.
Good call. Forgot about that :|
|
We also need to include references to zxing license. Probably both in the wiki and the open source dialog. |
|
@rnpenguin I agree on the license - We have other licenses that we need to include as well. I'd like to get #91 in before updating the preference panel. Joda Time, MongoDB, guava, zxing-android-minimal - Apache 2.0 |
… barcode Bumped compileSdkVersion and targetSdkVersion up
rnpenguin
force-pushed
the
wip/barcode#74
branch
from
e4184e3 to
e6720a7
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed receiver leak
Moar tests