Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.sh change for python #3577

Closed
Dave2526 opened this issue May 15, 2018 · 6 comments
Closed

setup.sh change for python #3577

Dave2526 opened this issue May 15, 2018 · 6 comments
Labels
Milestone

Comments

@Dave2526
Copy link

Hello,
last week I´ve installed Nightscout on my Raspberry Pi 3 (Latest update & upgrade) and there I found an Issue in the setup.sh file: The Packet "python-software-properties" is now called "software-properties-common".

@PieterGit
Copy link
Contributor

@Dave2526 thanks for the report. Did you try a release or the dev branch?
I don't know why python is included. I can't find any python references in Nightscout codebase for now.
I wonder if python is still needed. On the dev branch we can also upgrade to Node 10.

Would you like to try to create a PR to get this fixed? If you need help please join https://gitter.im/nightscout/public

@PieterGit
Copy link
Contributor

PieterGit commented Jul 10, 2018

@Dave2526 or somebody else. Could you test #3683
I think that should solve the problem in a better way. If your quick it will be released with 0.10.3, otherwise we need to postpone it.

@PieterGit PieterGit changed the title setup.sh change setup.sh change for python Jul 10, 2018
@Dave2526
Copy link
Author

Sorry, but at the moment I can't test it. Perhaps anyone else?

@PieterGit PieterGit modified the milestones: 0.10.3, 0.11.0 Aug 5, 2018
@PieterGit
Copy link
Contributor

@Dave2526 can you now test this PR? If not it won't be included in the 0.11 release.

@PieterGit
Copy link
Contributor

This PR has been integrated with the https://github.com/nightscout/cgm-remote-monitor/tree/needs_testing
branch. Please test that branch and report at this issue or at #4169

@PieterGit
Copy link
Contributor

Assuming fixed. @Dave2526 can you report if the fix works for you on RPI?
Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants