-
Notifications
You must be signed in to change notification settings - Fork 72k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundled features for 0.11 that need to be tested and approved before being merged #4169
Conversation
Dev update from nightscout
Refresh dev from nightscout
New branch dev -> loopalyzer-dev, cloned to Mac, edited index.js and pushing.
Merge loopalyzer-dev into loopalyzer
Update with latest dev; IOB/COB from NS client util
* Skipping Loopalyzer unless it is the selected tab * Showing message if more than one week duration selected
Update from dev - 2018-06-03 v4
Update from latest dev
Update from dev
Added fill-in using carb and insulin treatments to avoid gaps in graphs
… 8 users. According to Darren Lee @balshor Node 10.14.1 is available on Azure, see https://gitter.im/nightscout/public?at=5c2a50c70b7fc97caaca6211 or https://gist.github.com/balshor/f3bbb86ff98eeecefc5dd4bdb4118b1b
…te-monitor into 201812_needs_testing
Added #4170 on @jpcunningh request, see https://gitter.im/nightscout/public?at=5c2a838ababbc178b2096982 |
"traverse": "^0.6.6", | ||
"uglify-js": "^3.4.9", | ||
"uuid": "^3.2.1" | ||
"uglify-js": "^3.4.9" | ||
}, | ||
"devDependencies": { | ||
"benv": "^3.3.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to add "jsdom": "~11.11.0",
.
benv
brakes with 11.12 or later versions of jsdom.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpcunningh great find. I didn't understand why my tests did not run under Windows, but the Travis builds were fine. What platform do you use? I think we should try to seek for an alternative for benv
because is does not seem to be maintained.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I now noticed that Travis didn't work either. @sulkaharo do you have any idea why the error was not propagated to a failed build, see e.g. https://travis-ci.org/nightscout/cgm-remote-monitor/jobs/474055158
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PieterGit, I'm running Ubuntu 18.04.
Use npm released version instead of wip/generalize branch. This version will also make sure Nightscout won't crash if Dexcom servers are down.
@PieterGit, other than the issue noted above, I've been running this branch for 3 days without any issues. |
…-remote-monitor into 201812_needs_testing
…t/cgm-remote-monitor into 201812_needs_testing
…ningh/cgm-remote-monitor into 201812_needs_testing
PR with several PR's that need testing. Most of these issue have been reviewed, but have not gotten enough test by others. Because we don't want to merge PR's that have not been tested enough, I bundled these issues.
This PR includes issues labeled
needs_testing
and are milestoned for the 0.11 release. Seehttps://github.com/nightscout/cgm-remote-monitor/issues?utf8=%E2%9C%93&q=is%3Aopen+label%3A%22needs+testing%22++milestone%3A%220.11.0%22
Later: #4175 (upgrade share2nightscout-bridge to 0.2.0) was also added to this branch.
This includes: