Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend treatment form #228

Closed
wants to merge 3 commits into from
Closed

Extend treatment form #228

wants to merge 3 commits into from

Conversation

jasoncalabrese
Copy link
Member

WIP - NOT DONE

Tasks:

  • support for delayed entry
  • support for pre-bolus
  • support temp basals (+/- % for a duration in minutes)
  • support for combo boluses % now, duration of the rest
  • split note and question treatment types (will be used to notification level)

All treatment types:

screen shot 2014-11-04 at 11 31 53 pm

Carbs (pre-bolus):

screen shot 2014-11-04 at 11 25 55 pm

Carbs (when past/present/future):

screen shot 2014-11-04 at 11 26 14 pm

@mrinnetmaki
Copy link

Just a note re "support for combo boluses % now, duration of the rest", on Accu-Chek Combo I enter the 'amount now' in units, not in %.

@jasoncalabrese
Copy link
Member Author

Hi, @mrinnetmaki I have a feeling every pump will do things differently, wonder if there's something that will work for most people without a ton of options. Also you can join us on Gitter https://gitter.im/nightscout/public

@jasoncalabrese
Copy link
Member Author

@jimsiff, have you looked at the iob-cob branch yet? I want to keep manual entry simple, but still gather accurate timing data. I also want to figure out a generic display that makes sense no matter what pump your using.

@jimsiff
Copy link
Contributor

jimsiff commented Nov 11, 2014

@jasoncalabrese I haven't looked at iob-cob for almost a month. Scott was still putting the pieces together the last time I tried to run it. I'll spin up a site and take a look.

@jasoncalabrese
Copy link
Member Author

@jimsiff, I was thinking the select box next the the insulin and carbs would have the same function and the date/time in your mockup.

The idea is that the time of the insulin bolus wouldn't have to match the timing of the carbs. The could be custom in the select too that could open an input dialog. After setting one of the selects we may want to set both, probably some rule for that.

I like the idea of custom/configurable treatment types, I can imagine them including the alert level and what fields to display.

I think the export and filtering would be on the treatments page. Lots of cool things we could do there.

@jimsiff
Copy link
Contributor

jimsiff commented Nov 12, 2014

@jasoncalabrese I see... so the having the time/date in the carb and insulin fields would make the time/date at the top redundant. Makes sense. Which time/date would be the anchor for display on the CP timeline? Could there be a CP circle for both carb and bolus events, symlinked to the same CP entry?

I agree that export and filtering should be from the Treatments page.

@jasoncalabrese
Copy link
Member Author

@jimsiff I was thinking that it the times didn't match it would create 2 treatment entries, also thinking that we'd have the created_at timestamp and a new event_event(or something like that) timestamp. The we'd know when it was entered in addition to the actual time of the event

@jasoncalabrese jasoncalabrese self-assigned this Nov 22, 2014
@jasoncalabrese jasoncalabrese changed the title **WIP** Extend treatment form Extend treatment form Nov 22, 2014
@jasoncalabrese
Copy link
Member Author

Working on a different branch, with a different design for event time and pre-bolus

@jasoncalabrese jasoncalabrese deleted the wip/treat-time branch December 5, 2014 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants