Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mongo driver update & less frequent database polls #8026

Merged
merged 11 commits into from
Oct 12, 2023
Merged

Mongo driver update & less frequent database polls #8026

merged 11 commits into from
Oct 12, 2023

Conversation

sulkaharo
Copy link
Member

@sulkaharo sulkaharo commented May 29, 2023 •
edited
Loading

  • Increase debounce for data loads to 15 seconds and trigger a data-loaded event to process local data updates even if the call is debounced.
  • Updates the database drivers to latest.
  • Removes support for OpenAPS local file storage

Maybe fixes #8024

@bewest
Copy link
Member

bewest commented Jun 2, 2023

Nice upgrade to mongodb drivers!

@sulkaharo sulkaharo changed the title Less frequent Mongo updates Mongo driver update & less frequent database polls Jun 2, 2023
@bewest
Copy link
Member

bewest commented Jun 7, 2023

Testing this, and it does something weird in some of my test environments. On some environments it can't bootstrap the connection correctly, but it's not clear if it may be a server misconfiguration issue.

@RickyGrassmuck
Copy link

Looking forward to seeing this get merged!

I explored using FerretDB (An alternative to Mongodb that is backed by postgres), which requires using updated mongo driver compatible with Mongodb 6+ to work, as a replacement for Mongodb and early testing looked promising but I didn't have the bandwidth for diving in to fix all the little incompatiblies needed so I had to shelve the idea.

If/when this gets merged, definitely going to be revisiting that project and see if it's truly a viable option to replace Mongodb!

@RickyGrassmuck
Copy link

Testing this, and it does something weird in some of my test environments. On some environments it can't bootstrap the connection correctly, but it's not clear if it may be a server misconfiguration issue.

Happy to spin up some test instances and see if I can replicate the connection issues.

@bewest
Copy link
Member

bewest commented Aug 8, 2023

Howdy @RickyGrassmuck, this is on track to be merged. I've been ultra-conservative testing scenarios on databases that run in replica set and that have been migrated or have mixed upgrade/migration status or even broken cluster configurations.

@bewest
Copy link
Member

bewest commented Oct 12, 2023

Finally catching up on my backlog. Additional testing, and I like this. If the startup boot sequence will more predictably take 15 seconds instead of 5 seconds it might make a nice first-time contribution for someone.
Additionally, this looks ok in node 14, 16, and 18, so thinking about adding node 18 to the compat list.

bewest added 7 commits October 12, 2023 08:33
@bewest
allow running any version of LTS
3893eb4 
Given node 18 and 20, allow running on any LTS version of node.
We can block out bad versions if needed.
@bewest
n 14 && npm install
ebece1b 
Use npm install under node 14 generates different lock file.
@bewest
set expectation to take around 15 seconds for first load
48dfa22 
This patch adjusts the user feedback while the server is initializing to
communicate that Nightscout startup sequence should take closer to 15 second
than 5 seconds.
@bewest
Merge remote-tracking branch 'official/dev' into less_frequent_db_upd…
c6c0a0a 
…ates
@bewest
Allow any LTS version.
7819223
@bewest
n 14 && npm install
6964916 
Record output of npm instlal using oldest supported version.
@bewest
upgrade nightscout-connect@^0.0.12, npm install
97a603f 
Record changes from upgrading nightscout-connect to at least the latest
release, 0.0.12.
@bewest bewest merged commit 2757fe5 into dev Oct 12, 2023
@bewest bewest mentioned this pull request Oct 19, 2023
Closed
bewest added a commit that referenced this pull request Oct 19, 2023
@bewest
Revert "Merge pull request #8026 from nightscout/less_frequent_db_upd…
2e65b1d 
…ates"

This reverts commit 2757fe5, reversing
changes made to 4a461e5.
@bewest bewest mentioned this pull request Oct 19, 2023
Merged
bewest added a commit that referenced this pull request Oct 20, 2023
@bewest
Merge pull request #8115 from nightscout/hotfix/revert/8026
bfecbe7 
Revert "Merge pull request #8026 from nightscout/less_frequent_db_upd…
@bewest bewest mentioned this pull request Oct 20, 2023
Closed
@bewest
Copy link
Member

bewest commented Nov 5, 2024

Looking at bringing this back in...

@bewest bewest mentioned this pull request Nov 25, 2024
Open
bewest added a commit that referenced this pull request Nov 26, 2024
@bewest
Revert "Revert "Merge pull request #8026 from nightscout/less_frequen…
f2d32c8 
…t_db_updates""

This reverts commit 2e65b1d.
Try to bring back #8026.
@bewest bewest mentioned this pull request Nov 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sulkaharo @bewest @RickyGrassmuck