Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Request package to @cypress/request #26

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Migrate Request package to @cypress/request #26

merged 1 commit into from
Mar 11, 2024

Conversation

MadeinFrance
Copy link
Contributor

Fixes #25

artola
artola reviewed Feb 28, 2024
View reviewed changes
src/utils/requestHelper.js Outdated Show resolved Hide resolved
@MadeinFrance MadeinFrance force-pushed the remove-request branch 2 times, most recently from 1d819d5 to 38436cd Compare February 29, 2024 10:14
@MadeinFrance MadeinFrance requested a review from artola February 29, 2024 11:59
artola
artola reviewed Feb 29, 2024
View reviewed changes
src/utils/requestHelper.js Outdated Show resolved Hide resolved
@MadeinFrance MadeinFrance changed the title Migrate Request package to node-fetch Migrate Request package to @cypress/request Feb 29, 2024
@MadeinFrance MadeinFrance requested a review from artola February 29, 2024 16:03
@MadeinFrance MadeinFrance mentioned this pull request Feb 29, 2024
Closed
@AutomatedTester AutomatedTester merged commit 4cf0255 into nightwatchjs:main Mar 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artola artola artola approved these changes

@AutomatedTester AutomatedTester AutomatedTester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Security vulnerability - request@2.88.2
3 participants
@MadeinFrance @AutomatedTester @artola