fix #3469 REPL interface exits on error

nightwatchjs · Nov 17, 2022 · 25528ae · 25528ae
1 parent 0c52846
commit 25528ae
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/lib/api/client-commands/debug.js b/lib/api/client-commands/debug.js
@@ -1,6 +1,7 @@
 const util = require('util');
 const EventEmitter = require('events');
 const NightwatchRepl = require('../../testsuite/repl');
+const Debuggability = require('../../utils/debuggability.js');
 
 /**
  * This command halts the test execution and provides users with a REPL interface where they can type
@@ -46,9 +47,13 @@ Debug.prototype.command = function(config, cb) {
   const context = {
     browser: this.api
   };
+  // Before starting REPL server, Ser debugMode to true
+  Debuggability.debugMode = true;
   repl.startServer(context);
 
   repl.onExit(() => {
+    // On exit, Set debugMode to false
+    Debuggability.debugMode = false;
     // if we have a callback, call it right before the complete event
     if (cb) {
       cb.call(this.client.api);

diff --git a/lib/core/treenode.js b/lib/core/treenode.js
@@ -1,5 +1,6 @@
 const EventEmitter = require('events');
 const Utils = require('../utils');
+const Debuggability = require('../utils/debuggability.js');
 
 class TreeNode {
   get command() {
@@ -109,6 +110,11 @@ class TreeNode {
 
   handleError(err) {
     err.abortOnFailure = err.abortOnFailure || err.abortOnFailure === undefined;
+
+    // Set abortOnFailure to false when command is being executed in debugMode
+    if (Debuggability.debugMode) {
+      err.abortOnFailure = false;
+    }
     let errorName = err.name !== 'Error' ? `[${err.name}] ` : '';
     let originalError = `${errorName}${err.message}`;
 

diff --git a/lib/utils/debuggability.js b/lib/utils/debuggability.js
@@ -7,6 +7,14 @@ class Debuggability {
     this._stepOverAndPause = value;
   }
 
+  static get debugMode() {
+    return this._debugMode;
+  }
+
+  static set debugMode(value) {
+    this._debugMode = value;
+  }
+
   static reset() {
     this._stepOverAndPause = false;
   }