update baseHook to handle hook done function inside command callback (#…

…3636)
nightwatchjs · Mar 24, 2023 · 72ec9b5 · 72ec9b5
1 parent c7ac9c3
commit 72ec9b5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/lib/testsuite/hooks/_basehook.js b/lib/testsuite/hooks/_basehook.js
@@ -90,12 +90,9 @@ class BaseHook {
             }
 
             if (this.context.queue && this.context.queue.inProgress) {
-              process.nextTick(() => {
-
-                this.context.queue.once('queue:finished', _ => {
-                  runnableDone && runnableDone(result);
-                  doneFn(result);
-                });
+              this.context.queue.once('queue:finished', _ => {
+                runnableDone && runnableDone(result);
+                doneFn(result);
               });
             } else {
               runnableDone && runnableDone(result);

diff --git a/test/sampletests/beforewithcommand/commandInsideBefore.js b/test/sampletests/beforewithcommand/commandInsideBefore.js
@@ -24,8 +24,9 @@ module.exports = {
     client.end();
   },
 
-  afterEach: function(client) {
+  afterEach: function(client, cb) {
     client.globals.calls++;
+    client.end(cb);
   },
 
   after: function(client) {