Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aliases for getCssProperty command in new Element API #4167

Closed
3 tasks
Ayush-Vish opened this issue Apr 4, 2024 · 1 comment · Fixed by #4168
Closed
3 tasks

Add aliases for getCssProperty command in new Element API #4167

Ayush-Vish opened this issue Apr 4, 2024 · 1 comment · Fixed by #4168
Labels
enhancement

Comments

@Ayush-Vish
Copy link
Contributor

Ayush-Vish commented Apr 4, 2024 •
edited
Loading

Description

The getCssProperty should have the following alias

  • css
  • getCssValue

The getCssProperty can be found in the lib/api/web-element/commands directory.

TODO

  • Add missing aliases
  • Add tests for the added aliases
  • Add missing types and tests for the added types

Suggested solution

No response

Alternatives / Workarounds

No response

Additional Information

No response
@Ayush-Vish Ayush-Vish mentioned this issue Apr 4, 2024
Merged
6 tasks
@Ayush-Vish
Copy link
Contributor Author

Ayush-Vish commented Apr 4, 2024 •
edited
Loading

@garg3133 @beatfactor I have start woking on this issue.
Please review the PR.
Explanation is simple I have added the alias for getCssPropery in the scoped-element.js and added Neccesary typings and test for both alias.

@garg3133 garg3133 mentioned this issue Apr 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: added .css() and .getCssValue() as an alias for .getCssProperty() Ayush-Vish/nightwatch
1 participant
@Ayush-Vish