Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added .css() and .getCssValue() as an alias for .getCssProperty() #4168

Merged

Conversation

Ayush-Vish
Copy link
Contributor

@Ayush-Vish Ayush-Vish commented Apr 4, 2024

fixes #4167

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • [.] Before marking your PR for review, please test and verify your changes by making appropriate modifications to any of the Nightwatch example tests (present in examples/tests directory of the project) and running them. ecosia.js and duckDuckGo.js are good examples to work with.
  • [.] Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • [.] If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@Ayush-Vish
Copy link
Contributor Author

Done all the required changes for this Pr as Well

@Ayush-Vish Ayush-Vish changed the title Feat: added aliases for getCssProperty Feat: added .css() and .cssValue() as an alias for .getCssProperty() Apr 18, 2024
Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the merge conflict in this PR.

Comment on lines 138 to 143

// Extra tests
it('test browser.element().css()', async function () {


const resultPromise = this.client.api.element('#signupSection').css('height');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move these test cases to their respective places. And if you see clearly, the test case for .css() is already present in the file.

@garg3133 garg3133 changed the title Feat: added .css() and .cssValue() as an alias for .getCssProperty() Feat: added .css() and .getCssValue() as an alias for .getCssProperty() Apr 18, 2024
Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@Ayush-Vish
Copy link
Contributor Author

Looks good, thanks!

Thankyou.

@garg3133 garg3133 merged commit 0b3cfb1 into nightwatchjs:main Apr 18, 2024
17 checks passed
dikwickley pushed a commit to dikwickley/nightwatch that referenced this pull request Oct 15, 2024
…4168)



Co-authored-by: Priyansh Garg <priyanshgarg30@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add aliases for getCssProperty command in new Element API
2 participants