Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change settings.json file name to nightwatch.json #68

Closed
tfitch opened this issue Feb 26, 2014 · 5 comments
Closed

Change settings.json file name to nightwatch.json #68

tfitch opened this issue Feb 26, 2014 · 5 comments

Comments

@tfitch
Copy link

tfitch commented Feb 26, 2014

Similar to a change the Bower project went through. They originally called their config file components.json but have since changed it to bower.json. bower/bower#39

I was looking to embed Nightwatch in to an existing project and felt the settings.json file name was too generic. Yes with the -c arg I can change the config file's name, but for visibility and promtion of the project's brand I think nightwatch.json should become the standard.

When someone sees a nightwatch.json file in a project they'll know the E2E testing is probably in place. When they see a settings.json they'll wonder what that is.

Thank you.

@wayneseymour
Copy link

I completely agree.

@beatfactor
Copy link
Member

Ok, good point. This discussion is also going on in the mailing list, so it will probably happen in the next major release (v0.4):

https://groups.google.com/forum/#!topic/nightwatchjs/SfdH6F2g87g

@wayneseymour
Copy link

THUMBS UP!

@davidlinse
Copy link
Contributor

+1

1 similar comment
@scalvert
Copy link
Contributor

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants