Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features/supporting cucumber cli options #2978

Merged
merged 8 commits into from
Jan 12, 2022
Merged

Features/supporting cucumber cli options #2978

merged 8 commits into from
Jan 12, 2022

Conversation

gravityvi
Copy link
Member

@gravityvi gravityvi commented Dec 14, 2021 •
edited
Loading

Changes

@gravityvi
Copy link
Member Author

--config CLI option would create conflict with existing --config CLI option in Nightwatch. I don't think that would be a blocker as we can still use the default file name (cucumber.js) to create profiles for the cucumber runner.

@gravityvi gravityvi linked an issue Dec 15, 2021 that may be closed by this pull request
[Enhancement] Add full support for cucumber.js CLI options #2962
Closed
vaibhavsingh97
vaibhavsingh97 requested changes Dec 15, 2021
View reviewed changes
examples/cucumber-js/README.md Show resolved Hide resolved
lib/runner/test-runners/cucumber.js Outdated Show resolved Hide resolved
lib/runner/test-runners/cucumber.js Show resolved Hide resolved
test/src/runner/cucumber-integration/testCliArgs.js Show resolved Hide resolved
@gravityvi gravityvi requested a review from beatfactor December 15, 2021 15:07
@beatfactor beatfactor merged commit ab6fdef into nightwatchjs:main Jan 12, 2022
@gravityvi gravityvi deleted the features/supporting-cucumber-cli-options branch January 12, 2022 10:00
@phil-davis phil-davis mentioned this pull request Jan 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatfactor beatfactor Awaiting requested review from beatfactor

@vaibhavsingh97 vaibhavsingh97 Awaiting requested review from vaibhavsingh97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement] Add full support for cucumber.js CLI options
3 participants
@gravityvi @vaibhavsingh97 @beatfactor