Upgrade Selenium to 4.1.1 #2995

AutomatedTester · 2022-01-11T10:11:58Z

checkResponse was deprecated in Selenium and has been removed. This PR moves to the method that was suggested.

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
If you're fixing a bug also create an issue if one doesn't exist yet;
If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
Do not include changes that are not related to the issue at hand;
Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
Always add unit tests - PRs without tests are most of the times ignored.

CLAassistant · 2022-01-11T10:12:12Z

All committers have signed the CLA.

test/src/api/expect/testExpectVisible.js

beatfactor

A few remarks. Due to the high volume of refactoring and style changes, this PR makes it very difficult to review.

Is it possible to leave out the changes to spaces?
Is it entirely necessary to use the w3c endpoints? in terms of tests, I don't think it makes any difference if we use jwp or w3c, but it makes it very difficult to review the actual meaningful changes.

lib/api/expect/cookie.js

beatfactor · 2022-02-21T16:28:37Z

lib/api/expect/cookie.js

-        this.resultValue = result ? result.value : {};
+        if (result && result.value) {
+          if (Array.isArray(result.value)) {
+            this.resultValue = result.value[0].value;


If result.value is an empty array, this will throw an error.

good catch!

I've added a ternary here. Looking at the spec, the likelihood of it being empty for named cookies is low because it should error if it can't return anything.

I'm not sure how to add a test as it seems to kick the retry code in so any guidance would be appreciated.

AutomatedTester · 2022-02-22T10:17:40Z

A few remarks. Due to the high volume of refactoring and style changes, this PR makes it very difficult to review.

I can revert these but most where put in when running npm run eslint -- --fix

Is it possible to leave out the changes to spaces? Is it entirely necessary to use the w3c endpoints? in terms of tests, I don't think it makes any difference if we use jwp or w3c, but it makes it very difficult to review the actual meaningful changes.

It makes a big difference. The Mocks are only looking for JWP but Selenium is no longer calling those so we were getting test failures. The necessary changes to get tests passing where done without changing the results of the tests.

beatfactor · 2022-02-22T12:01:02Z

test/lib/mocks/mocks-jsonwire.yaml

@@ -233,7 +233,7 @@ mocks:
    sessionId: *sessionId
    status: 0

- url: '/wd/hub/session/1352110219202/log'
+- url: '/wd/hub/session/1352110219202/se/log'


is this a valid endpoint?

yes, the /se/ is namespacing it purely for Selenium and showing that it is not in the standard.

lib/transport/selenium-webdriver/index.js

This handles the deprecations and updates to endpoints that selenium only supports now.

…ing named cookie

This reverts commit 72b7dfa.

* Upgrade to Selenium 4.1.1 This handles the deprecations and updates to endpoints that selenium only supports now.

AutomatedTester force-pushed the checkresponse_deprecation branch from 4dfb91a to e376ad8 Compare January 11, 2022 10:24

vaibhavsingh97 approved these changes Jan 11, 2022

View reviewed changes

gravityvi approved these changes Jan 12, 2022

View reviewed changes

AutomatedTester marked this pull request as draft January 18, 2022 10:59

vaibhavsingh97 mentioned this pull request Jan 19, 2022

after you updated selenium webdriver, now everything is failing #2999

Closed

vaibhavsingh97 linked an issue Jan 19, 2022 that may be closed by this pull request

after you updated selenium webdriver, now everything is failing #2999

Closed

vaibhavsingh97 mentioned this pull request Jan 20, 2022

[CI Failing]: Github Action passing even on test failures #3001

Closed

AutomatedTester force-pushed the checkresponse_deprecation branch 3 times, most recently from 33be871 to 12e544d Compare January 26, 2022 10:09

AutomatedTester force-pushed the checkresponse_deprecation branch 2 times, most recently from 2207784 to 0e71955 Compare February 21, 2022 15:02

AutomatedTester marked this pull request as ready for review February 21, 2022 15:03

AutomatedTester changed the title ~~Move to throwDecodedError as checkResponse deprecated~~ Upgrade Selenium to 4.1.1 Feb 21, 2022

gravityvi approved these changes Feb 21, 2022

View reviewed changes

gravityvi reviewed Feb 21, 2022

View reviewed changes

test/src/api/expect/testExpectVisible.js Outdated Show resolved Hide resolved

beatfactor reviewed Feb 21, 2022

View reviewed changes

beatfactor reviewed Feb 22, 2022

View reviewed changes

AutomatedTester force-pushed the checkresponse_deprecation branch from 9c05648 to ead8ddc Compare February 24, 2022 11:44

gravityvi mentioned this pull request Mar 1, 2022

[Enhancement] Refactor Mocks for tests #3076

Open

AutomatedTester force-pushed the checkresponse_deprecation branch from ead8ddc to 9065d6d Compare March 1, 2022 10:44

AutomatedTester force-pushed the checkresponse_deprecation branch from 9065d6d to 5a45ace Compare March 9, 2022 14:15

beatfactor reviewed Mar 11, 2022

View reviewed changes

lib/transport/selenium-webdriver/index.js Show resolved Hide resolved

AutomatedTester added 5 commits March 17, 2022 11:07

Upgrade to Selenium 4.1.1

06081b0

This handles the deprecations and updates to endpoints that selenium only supports now.

review comments fix

dcfbb75

Handle empty cookie though this shouldn't happen in reality with gett…

895d528

…ing named cookie

move order of error handling as per comments

2b28c76

Revert "move order of error handling as per comments"

a2a525c

This reverts commit 72b7dfa.

AutomatedTester force-pushed the checkresponse_deprecation branch from 8ec5dc5 to a2a525c Compare March 17, 2022 11:09

beatfactor merged commit e64584e into main Mar 22, 2022

beatfactor deleted the checkresponse_deprecation branch March 22, 2022 21:05

gravityvi pushed a commit to gravityvi/nightwatch that referenced this pull request Mar 24, 2022

Upgrade Selenium to 4.1.1 (nightwatchjs#2995)

6e0c972

* Upgrade to Selenium 4.1.1 This handles the deprecations and updates to endpoints that selenium only supports now.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade Selenium to 4.1.1 #2995

Upgrade Selenium to 4.1.1 #2995

AutomatedTester commented Jan 11, 2022

CLAassistant commented Jan 11, 2022 •

edited

Loading

beatfactor left a comment

beatfactor Feb 21, 2022

AutomatedTester Feb 22, 2022

AutomatedTester Feb 24, 2022

AutomatedTester commented Feb 22, 2022

beatfactor Feb 22, 2022

AutomatedTester Feb 22, 2022

Upgrade Selenium to 4.1.1 #2995

Upgrade Selenium to 4.1.1 #2995

Conversation

AutomatedTester commented Jan 11, 2022

CLAassistant commented Jan 11, 2022 • edited Loading

beatfactor left a comment

Choose a reason for hiding this comment

beatfactor Feb 21, 2022

Choose a reason for hiding this comment

AutomatedTester Feb 22, 2022

Choose a reason for hiding this comment

AutomatedTester Feb 24, 2022

Choose a reason for hiding this comment

AutomatedTester commented Feb 22, 2022

beatfactor Feb 22, 2022

Choose a reason for hiding this comment

AutomatedTester Feb 22, 2022

Choose a reason for hiding this comment

CLAassistant commented Jan 11, 2022 •

edited

Loading