Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mocha wrong exitcode issue #3039

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

swrdfish
Copy link
Member

@swrdfish swrdfish commented Feb 8, 2022

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@swrdfish swrdfish linked an issue Feb 9, 2022 that may be closed by this pull request
lib/utils/index.js Outdated Show resolved Hide resolved
lib/transport/selenium-webdriver/method-mappings.js Outdated Show resolved Hide resolved
lib/runner/process-listener.js Outdated Show resolved Hide resolved
lib/transport/selenium-webdriver/method-mappings.js Outdated Show resolved Hide resolved
@swrdfish swrdfish requested a review from beatfactor March 3, 2022 14:44
@swrdfish
Copy link
Member Author

Moved the test fixes to #3120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI Failing]: Github Action passing even on test failures
4 participants