-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mocha wrong exitcode issue #3039
Merged
beatfactor
merged 1 commit into
nightwatchjs:main
from
swrdfish:issue/mocha-wrong-exitcode
Mar 25, 2022
Merged
Fix mocha wrong exitcode issue #3039
beatfactor
merged 1 commit into
nightwatchjs:main
from
swrdfish:issue/mocha-wrong-exitcode
Mar 25, 2022
+2
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravityvi
reviewed
Feb 9, 2022
gravityvi
approved these changes
Feb 9, 2022
test/src/runner/cucumber-integration/testCucumberTestsInParallel.js
Outdated
Show resolved
Hide resolved
beatfactor
requested changes
Feb 19, 2022
beatfactor
reviewed
Mar 22, 2022
beatfactor
reviewed
Mar 22, 2022
beatfactor
reviewed
Mar 22, 2022
lib/transport/selenium-webdriver/service-builders/base-service.js
Outdated
Show resolved
Hide resolved
beatfactor
reviewed
Mar 22, 2022
beatfactor
reviewed
Mar 23, 2022
beatfactor
reviewed
Mar 23, 2022
swrdfish
commented
Mar 24, 2022
swrdfish
force-pushed
the
issue/mocha-wrong-exitcode
branch
from
March 25, 2022 15:25
ba18ab4
to
6bc04f6
Compare
Moved the test fixes to #3120 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.
features/my-new-feature
orissue/123-my-bugfix
);