Add global app property.

[garg3133]

No description provided.

[swrdfish]

@garg3133 why do we need this?

[garg3133]

@swrdfish This was a suggestion made by Vishal to have an app variable globally just like the browser variable that users can use when writing tests for mobile apps.

[swrdfish]

Sound good, also can you add a simple test?

[garg3133]

I tried to look through the code, but couldn't find any tests written for any of the other global variables. So, maybe we can just have a example test written in examples/ folder, which is using app as a global variable?

[vaibhavsingh97]

Nit: we can use defineProperties, and define both app and browser

[garg3133]

IIUC Object.defineProperties cannot be used to add the same descriptor to two properties, but is used to add all the properties in one go. But since all the properties are added to Nightwatch separately in this file, it makes more sense to me to use defineProperty only just to have a consistent pattern through the file.

But if the problem is with the repetition of the same descriptor for the two properties, we can maybe do something like this?

const nightwatchApiDescriptor = {
  configurable: true,
  get() {
    if (global.browser) {
      return global.browser;
    }

    const err = new TypeError('Nightwatch client is not yet available.');
    err.addDetailedErr = true;

    throw err;
  }
};

Object.defineProperty(Nightwatch, 'browser', nightwatchApiDescriptor);

Object.defineProperty(Nightwatch, 'app', nightwatchApiDescriptor);

[beatfactor]

Yes, can you do the refactoring to avoid repeating the code?

[garg3133]

Done

[gravityvi]

should we add a basic high-level in apidemos test using global app property?

for example:

it('Search for Nightwatch', async function() {
  app  // available globally
    .click('id', 'org.wikipedia:id/search_container')
    .sendKeys('id', 'org.wikipedia:id/search_src_text', 'Nightwatch')
    .click({selector: 'org.wikipedia:id/page_list_item_title', locateStrategy: 'id', index: 0})
});