Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Selenium Version to 4.8.0 #3586

Merged
merged 2 commits into from
Mar 14, 2023
Merged

Bump Selenium Version to 4.8.0 #3586

merged 2 commits into from
Mar 14, 2023

Conversation

AutomatedTester
Copy link
Member

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@gravityvi
Copy link
Member

Checked the selenium changelog. There shouldn't be any breaking changes with this.

@AutomatedTester AutomatedTester merged commit da058dc into main Mar 14, 2023
@AutomatedTester AutomatedTester deleted the selenium4.8.0 branch March 14, 2023 18:07
harshit-bs pushed a commit to harshit-bs/nightwatch that referenced this pull request Mar 16, 2023
* Bump Selenium Version to 4.8.0

* Removed NodeJS 12.x support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants