Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect build duration in HTML Report #3658

Merged

Conversation

vaibhavsingh97
Copy link
Member

Fixes #3578
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@vaibhavsingh97 vaibhavsingh97 force-pushed the chore/fix-html-reporter-time branch from 07050c1 to dcb49d8 Compare March 28, 2023 14:52
@vaibhavsingh97 vaibhavsingh97 requested a review from swrdfish March 28, 2023 14:53
Copy link
Member

@swrdfish swrdfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beatfactor beatfactor merged commit ac2fe7d into nightwatchjs:main Mar 29, 2023
@vaibhavsingh97 vaibhavsingh97 deleted the chore/fix-html-reporter-time branch March 29, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build duration is not correct in new HTML report
3 participants