Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix build duration for HTML Reporter #3683

Merged
merged 4 commits into from
Apr 7, 2023

Conversation

vaibhavsingh97
Copy link
Member

@vaibhavsingh97 vaibhavsingh97 commented Apr 6, 2023

Fixes #3578

This PR depends on nightwatchjs/html-reporter#30

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@vaibhavsingh97 vaibhavsingh97 requested a review from swrdfish April 6, 2023 10:40
@vaibhavsingh97 vaibhavsingh97 marked this pull request as draft April 6, 2023 11:38
@vaibhavsingh97 vaibhavsingh97 marked this pull request as ready for review April 7, 2023 07:26
@vaibhavsingh97 vaibhavsingh97 requested a review from gravityvi April 7, 2023 07:26
lib/reporter/reporters/html.js Show resolved Hide resolved
@gravityvi gravityvi merged commit f258cf6 into nightwatchjs:main Apr 7, 2023
@vaibhavsingh97 vaibhavsingh97 deleted the fix/build-duration branch April 7, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build duration is not correct in new HTML report
3 participants