Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for Firefox namespace commands #3780

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Add types for Firefox namespace commands #3780

merged 3 commits into from
Jul 4, 2023

Conversation

Priyanka0613
Copy link
Contributor

Added Firefox namespace commands:

  1. getContext()
  2. setContext()
  3. installAddon()
  4. uninstallAddon()

garg3133
garg3133 reviewed Jun 26, 2023
View reviewed changes
Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Priyanka0613! Apart from the below review comment, these changes LGTM!

types/index.d.ts Outdated Show resolved Hide resolved
vaibhavsingh97
vaibhavsingh97 reviewed Jun 27, 2023
View reviewed changes
Copy link
Member

@vaibhavsingh97 vaibhavsingh97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTY, just one small question

types/index.d.ts Show resolved Hide resolved
types/index.d.ts Outdated Show resolved Hide resolved
@AutomatedTester AutomatedTester merged commit 90165d5 into nightwatchjs:main Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garg3133 garg3133 garg3133 approved these changes

@vaibhavsingh97 vaibhavsingh97 vaibhavsingh97 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Priyanka0613 @vaibhavsingh97 @garg3133 @AutomatedTester