Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move network-related commands to .network namespace. #3797

Merged
merged 17 commits into from
Jul 19, 2023
Merged

Move network-related commands to .network namespace. #3797

merged 17 commits into from
Jul 19, 2023

Conversation

yashPratp983
Copy link
Contributor

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@CLAassistant
Copy link

CLAassistant commented Jul 10, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

garg3133
garg3133 reviewed Jul 10, 2023
View reviewed changes
lib/api/client-commands/network/captureNetworkRequests.js Outdated Show resolved Hide resolved
lib/api/client-commands/network/captureNetworkRequests.js Outdated Show resolved Hide resolved
lib/api/client-commands/network/captureNetworkRequests.js Outdated Show resolved Hide resolved
lib/api/client-commands/network/mockNetworkResponse.js Outdated Show resolved Hide resolved
tsconfig.json Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 10, 2023 •
edited
Loading

Status

  • ✅ Type files updated!

@yashPratp983 yashPratp983 changed the title Move to namespace Move network-related commands to .network namespace. Jul 10, 2023
@yashPratp983 yashPratp983 requested a review from garg3133 July 10, 2023 10:03
garg3133
garg3133 reviewed Jul 10, 2023
View reviewed changes
tsconfig.json Outdated Show resolved Hide resolved
lib/api/client-commands/network/mockResponse.js Show resolved Hide resolved
@yashPratp983 yashPratp983 requested a review from garg3133 July 10, 2023 11:23
@yashPratp983 yashPratp983 requested a review from garg3133 July 13, 2023 18:10
garg3133
garg3133 approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @yashPratp983! This PR looks complete now.

Just one small request:

lib/api/client-commands/network/setConditions.js Outdated Show resolved Hide resolved
@yashPratp983
modified the JS/TS doc for setNetworkCondition in index.d.ts and setC…
b52808a 
…onditions.js and modified test for type of setNetworkConditions
@yashPratp983 yashPratp983 requested a review from garg3133 July 14, 2023 19:33
@yashPratp983
updated js/ts doc of setNetworkConditions in types/test/index.d.ts an…
52d307e 
…d lib/api/clientCommands/network/setConditions to use describe syntax
garg3133
garg3133 reviewed Jul 17, 2023
View reviewed changes
types/index.d.ts Outdated Show resolved Hide resolved
@yashPratp983 yashPratp983 requested a review from garg3133 July 17, 2023 15:16
@beatfactor beatfactor merged commit 3cf114f into nightwatchjs:main Jul 19, 2023
yashPratp983 added a commit to yashPratp983/nightwatch that referenced this pull request Jul 25, 2023
@yashPratp983
Move network-related commands to .network namespace. (nightwatchjs#3797)
f91797c
yashPratp983 added a commit to yashPratp983/nightwatch that referenced this pull request Jul 25, 2023
@yashPratp983
Move network-related commands to .network namespace. (nightwatchjs#3797)
c3182ba
yashPratp983 added a commit to yashPratp983/nightwatch that referenced this pull request Jul 25, 2023
@yashPratp983
Move network-related commands to .network namespace. (nightwatchjs#3797)
18c2c2c
yashPratp983 added a commit to yashPratp983/nightwatch that referenced this pull request Jul 25, 2023
@yashPratp983
Move network-related commands to .network namespace. (nightwatchjs#3797)
ea5feec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garg3133 garg3133 garg3133 approved these changes

@swrdfish swrdfish swrdfish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yashPratp983 @CLAassistant @swrdfish @garg3133 @beatfactor