Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing isEnabled command in new Element API #4041

Merged
merged 13 commits into from
Feb 28, 2024

Conversation

subhajit20
Copy link
Contributor

Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

fix - #4032

  • Create a new branch from master issue/isEnabled_command_4032
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@subhajit20 subhajit20 changed the title Added missing isEnabled command in new Element API Added missing isEnabled command in new Element API Feb 23, 2024
@subhajit20
Copy link
Contributor Author

Hey @garg3133 , is there any changes needed? please let me know

@garg3133
Copy link
Member

Same comment as posted on #4039: #4039 (comment)

@subhajit20
Copy link
Contributor Author

Same comment as posted on #4039: #4039 (comment)

Hey, I have made some changes.
Can you check once

@subhajit20
Copy link
Contributor Author

Hey @garg3133 also I executed the test and type test.
Screenshot 2024-02-24 at 3 23 05 PM

@subhajit20
Copy link
Contributor Author

Hey @garg3133 , I have made certain changes and worked according to the previous pr.
Can you please now check my pr?

Copy link
Member

@garg3133 garg3133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@subhajit20
Copy link
Contributor Author

Looks good now!

Cool, sorry for making those silly mistakes.
Thanks for your guidance !!

@garg3133 garg3133 merged commit f9615e5 into nightwatchjs:main Feb 28, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants