Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rect() as alias for getRect() command. #4128

Merged

Conversation

dikwickley
Copy link
Contributor

Adds one of the alias mentioned in #3901
Thanks in advance for your contribution. Please follow the below steps in submitting a pull request, as it will help us with reviewing it quicker.

  • Create a new branch from master (e.g. features/my-new-feature or issue/123-my-bugfix);
  • If you're fixing a bug also create an issue if one doesn't exist yet;
  • If it's a new feature explain why do you think it's necessary. Please check with the maintainers beforehand to make sure it is something that we will accept. Usually we only accept new features if we feel that they will benefit the entire community;
  • Please avoid sending PRs which contain drastic or low level changes. If you are certain that the changes are needed, please discuss them beforehand and indicate what the impact will be;
  • If your change is based on existing functionality please consider refactoring first. Pull requests that duplicate code will most likely be ignored;
  • Do not include changes that are not related to the issue at hand;
  • Follow the same coding style with regards to spaces, semicolons, variable naming etc.;
  • Always add unit tests - PRs without tests are most of the times ignored.

@dikwickley
Copy link
Contributor Author

sanity test
image

lib/api/web-element/commands/getRect.js Outdated Show resolved Hide resolved
types/web-element.d.ts Outdated Show resolved Hide resolved
types/tests/webElement.test-d.ts Show resolved Hide resolved
@dikwickley dikwickley requested a review from garg3133 March 17, 2024 18:58
@garg3133
Copy link
Member

Also, not sure if I told you this before, always use imperative style while writing commits or PR titles.

For example, the PR title should be: "Add rect() as alias for getRect() command."

@dikwickley dikwickley changed the title added alias for rect() for getRect() Add rect() as alias for getRect() command. Mar 17, 2024
@dikwickley
Copy link
Contributor Author

Also, not sure if I told you this before, always use imperative style while writing commits or PR titles.

For example, the PR title should be: "Add rect() as alias for getRect() command."

My bad, you have mentioned it before, will be careful onwards

@AutomatedTester AutomatedTester merged commit b4e273a into nightwatchjs:main Mar 18, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants