Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the queue tree from resolving in between the testcase. #4322

Closed
wants to merge 1 commit into from

Conversation

garg3133
Copy link
Member

@garg3133 garg3133 commented Dec 5, 2024

No description provided.

Copy link

github-actions bot commented Dec 5, 2024

Status

  • ❌ No modified files found in the types directory.
    Please make sure to include types for any changes you have made. Thank you!.

@garg3133
Copy link
Member Author

This does not work well with some hooks because for the this.runFn() (in lib/testsuite/runnable.js) to resolve for some hooks, the queue:finished event must be emitted from the done() method in lib/core/queue.js. But, in this implementation, the done() method of queue would never reach the this.emit() line because the done() function of asynctree.js wouldn't run (and clear the tree) until the this.runFn() is resolved (and this.currentResult.settled is set to true).

So, a situation of deadlock arises and the test run gets stuck.

@garg3133 garg3133 closed this Dec 27, 2024
@garg3133
Copy link
Member Author

#4325 is a better version of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant