Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modernize clipboard component with hooks. #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eightypop
Copy link

uses hooks instead of component lifecycle

note: how can i test this, i made changes but not sure how to test them.

@nihey
Copy link
Owner

nihey commented Oct 25, 2019

@whatknight

Thanks for the major contribution, I'll take some time next week to review it and merge it.

As for testing, I usually insert it into a project by linking it on its dependencies (ln -s <path to your react-clipboard.js> ./node_modules/react-clipboard.js)

@obsd
Copy link

obsd commented Mar 13, 2022

@nihey any chance working on that soon?
Let me know if I can help in any way

@nihey
Copy link
Owner

nihey commented Mar 18, 2022

@obsd Thanks for reviving this, yes, I should work on it soon, probably by next week.

One thing that would really make the review & test process more simple are some tests, some end to end tests with something like Cypress would really be appreciated.

@CosminPerRam
Copy link

Heyo, any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants