-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overwritten export (#36) by adding a backwards compatible dist/hashids.js fallback file #53
Conversation
added a backwards compatible dist/hashids.js fallback file for CJS to fix #36
@niieani Thank you, this is great! Do you know what's up with https://travis-ci.org/ivanakimov/hashids.js/jobs/423206991 ? Also, |
Ah, it seems babel's preset-env by default targets what's compatibile with Node >= 6. I can add a Any node version will use the Then there's support for We could probably drop the 0.xx versions of Node from Travis. As for Node v4, it's up to you. |
I've dropped all unsupported Node versions (4 is no longer supported by the Node organization), if you deem that incorrect we can just adjust the setting in package.json and rebuild again. I've also added a "browser" prop to point to the minified version and added a "module" one for builders that support ES Modules, but don't support the |
@niieani Many thanks for all the changes. I guess since maintenance cycle is over for v4, we can probably drop it. But we'd have to update either major or minor version, so devs are aware of the changes. Think you could update the changelog with your updates, and then I merge? |
Thank you @niieani. I updated the changelog since |
@niieani does the current code look release-ready to you? |
@ivanakimov yeah, it looks fine. |
Thanks for all the changes @niieani 👍 |
Works perfectly https://codesandbox.io/s/rmk16j6q8m |
Hi @ivanakimov I noticed a regression in my node.js (version 8 + babel) app since 1.2.1 (was previously 1.1.4):
When rolling back to @1.1.4 explicitly the issue is gone. |
Fix overwritten export (#36) by adding a backwards compatible dist/hashids.js fallback file
Updates babel to v7 and additionally adds support for ES modules under Node (.mjs).