Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows #286

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

codemasher
Copy link
Contributor

Hey,

this PR updates the workflow runs to use the latest versions of actions/checkout and ramsey/composer-install to stop the node.js deprecation warnings.

Further I have moved the PHPUnit cache directory under .build/.phpunit.cache (now looking at it, the leading . is a bit unnecessary) and cleaned up the .gitignore.

Cheers!

@lcobucci
Copy link
Collaborator

Thanks for the patch.

What's the benefit in changing the phpunit cache location to you?

@codemasher
Copy link
Contributor Author

codemasher commented Apr 23, 2024

This is a standard practice in all my projects

  • no random unrelated directories in the project root, the other (temporary) PHPUnit output paths (coverage, logs) are already in .build
  • easy to .gitignore anything not project related
  • only have to exclude only a single directory in the IDE (other than vendor)

Actually, we could do the same with the .phpbench directory, but i haven't looked at where it is created, nor ran it locally yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants