Remove xsi special treatment
#23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not map values inside `xsi:type` attribute. * Do not force `xsi` prefix for `XMLSchemaInstance`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Off-loads the
xsi:typeattribute and attribute value manipulation magic to downstream implementors. They have all the tools in place to perform the necessary changes.xsi:typeattribute.xsiprefix forXMLSchemaInstanceOff-loading to downstream implementors allows us to stay minimal (do one thing and do it right), but also give more power to downstream implementors to properly READ and WRITE XML.
This is a breaking change, to be shipped with a new major version.