-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.5.0 #11
Merged
Merged
V0.5.0 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent and drag.prevEvent to drag.prevMoveEvent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
container
is defined for theDraggable
instance.container
defined for theDraggable
instance.onPrepareScrollEffect
andonApplyScrollEffect
fromAutoScroll
. After careful investigation it seems that it's not needed to synchronously align the dragged elements after scroll, we can wait for the passive "scroll" event and schedule alignment for the next animation frame. This change actually improved performance during scrolling quite a bit.AutoScroll
.getElements
option toelements
, and update the arguments it receives.getFrozenStyles
option tofrozenStyles
, and update the arguments it receives.getPositionChange
option topositionModifiers
, and make it accept only an array of modifier functions, and update the arguments it receives.setPosition
option toapplyPosition
, and update the arguments it receives.getStartPosition
option in favor ofpositionModifiers
option, which is now called on drag start and end too.releaseElements
option in favor of doing the same logic in drag end event.createContainmentModifier
helper.