-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.3.0 #7
Merged
Merged
v0.3.0 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update is a big overhaul in all areas of the library. There are multiple breaking changes.
Summary
Eventti
andTikki
were bumped to their latest major versions, which cause breaking changes.createSnapModifier
.Sensor
interface to match the newEventti
API.Draggable
,DraggableDrag
andDraggableDragItem
internals. This also means some breaking changes as some props were renamed and moved around.Breaking Changes
Eventti
dependency was bumped from3.0.0
to4.0.0
we can't anymore use the existing API as is for unbinding event listeners.Eventti
doesn't allow anymore unbinding a listener with the listener reference only, it requires you to provide the listener id always. However, if you use thelistener
as thelistenerId
when binding the listener then you can unbind the listener using the listener reference also, just like before. This is a breaking change however and it reflects to allon
andoff
APIs throughout the library (including theSensor
interface). This is a step towards a more strict and predictable event emitter pattern so I like to believe the change is justified.DraggableDragItem
propertiespX
andpY
were removed in favour ofposition
property which hasx
andy
properties.DraggableDragItem
propertiesx
andy
were removed in favour ofclientRect
property, which is an object that hasleft
,top
,width
,height
properties.DraggableDragItem
'sclientRect
property (width
andheight
).DraggableDrag
properties were renamed:nextMoveEvent
->event
prevMoveEvent
->prevEvent
DraggableDrag
isStarted
property was removed as it's not needed anymore.