Fix CSS content property for Safari #1649
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safari does not pass content strings in double quotes, so they get ignored. This breaks packages such as Font-Awesome on Safari and iOS.
This was referenced Mar 1, 2019
mjsarfatti
added a commit
to mjsarfatti/html2canvas
that referenced
this pull request
Mar 1, 2019
|
Be advised #1649 pull request did not fix the problem for #1736. Fontawesome icons still show up as blank in Apple Safari after applying the above pull request in our local code. So fix still needed for this. Best, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari does not pass content strings in double quotes, so they get ignored. This breaks packages such as Font-Awesome on Safari and iOS.
Fixes #1610