fix: calculateBackgroundRendering may return width or height less than 1

[herbertxy]

Bug:
Bug reports:
Failed to execute 'createPattern' on 'CanvasRenderingContext2D': The image argument is a canvas element with a width or height of 0.

I console the value of width and height , find that the height is less than 1 caught this error

calculateBackgroundRendering function return value width height may be less than 1, then createPattern function throw error

Closing issues

Fixes #2981

[yorickshan]

thx for your pr, this fix has been merged to html2canvas-pro

[purplepeng]

Thanks all. I have the same issue use version 1.4.1. Can you merge the commit and publish a new version ?@niklasvh

[yorickshan]

Thanks all. I have the same issue use version 1.4.1. Can you merge the commit and publish a new version ?@niklasvh

Feel free to try using html2canvas-pro v1.5.6 or the most recent version.

[purplepeng]

Thanks all. I have the same issue use version 1.4.1. Can you merge the commit and publish a new version ?@niklasvh

Feel free to try using html2canvas-pro v1.5.6 or the most recent version.

@yorickshan I try to use your repo version, but the image convert from canvas is not right. With same options used in html2canvas, i can get right image.

html2canvas(element, { useCORS: true, allowTaint: true, backgroundColor: null })
  .then((canvas) => {
    if (canvas) {
      console.log('canvas', canvas);
      const data = canvas?.toDataURL('image/png');
      resolve({ data });
    } else {
      reject();
    }
  })

use html2canvas-pro

use html2canvas

[yorickshan]

Thanks all. I have the same issue use version 1.4.1. Can you merge the commit and publish a new version ?@niklasvh

Feel free to try using html2canvas-pro v1.5.6 or the most recent version.

@yorickshan I try to use your repo version, but the image convert from canvas is not right. With same options used in html2canvas, i can get right image.

html2canvas(element, { useCORS: true, allowTaint: true, backgroundColor: null })
  .then((canvas) => {
    if (canvas) {
      console.log('canvas', canvas);
      const data = canvas?.toDataURL('image/png');
      resolve({ data });
    } else {
      reject();
    }
  })

use html2canvas-pro

use html2canvas

I didn't reproduce the issue using the latest version (1.5.6). Please feel free to submit a detailed issue to html2canvas-pro, preferably with a minimal demo.