Tests background gradient

[SunboX]

Is this the right way to test gradient generation? Did I miss something?

[niklasvh]

It doesn't test whether the steps are correct or whether the correct colors are drawn though?

[SunboX]

Of curse, this will need to rewrite Generator.Canvas code. Would be the next step i will do. Than it´s possible to write new tests. But this one will check if it renders "something" or fails (blank image). Is this ok by now?
Should this code be moved to a new test,js file? Cause it´s not CSS "module" but "Generator" instead?

[niklasvh]

I think the test should first check whether it should even be generating a gradient. For example, if you use an IE<=9 browser, it shouldn't even be drawing a gradient, so it should just pass by not doing anything.

Something similar to if (background_image.substring(0,7) === "-webkit" || background_image.substring(0,3) === "-o-" || background_image.substring(0,4) === "-moz") {

(which would be lot better done in regexp to be fair... i'll need to update that check in preload.js :->)

It could be moved to its own file/module as well. Other than that, so far so good :)

[SunboX]

Ok, will look into this a bit more

[SunboX]

regexp could be:

if (/^(-webkit|-o|-moz|-ms|linear)-/.test(background_image)) {

[niklasvh]

I updated the tests/preload accordingly. It skips the test now for browsers that don't support gradients

[SunboX]

moved Generate tests into own module and fixed some small things:
https://github.com/SunboX/html2canvas/commits/tests-background-gradient

Will look into color-stops this week (+ add some tests)