Skip to content

Commit

Permalink
feat: first batch of fixing error handeling with type checks kubernet…
Browse files Browse the repository at this point in the history
…es#6906

Signed-off-by: nikzayn <nikhilvaidyar1997@gmail.com>
  • Loading branch information
nikzayn committed Jun 10, 2024
1 parent 83db225 commit 184fa9e
Show file tree
Hide file tree
Showing 18 changed files with 51 additions and 51 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -381,13 +381,13 @@ func setUpInformer(kubeClient kube_client.Interface, kind controllerKind) (cache
informer = appsinformer.NewDaemonSetInformer(kubeClient, apiv1.NamespaceAll,
resyncPeriod, cache.Indexers{cache.NamespaceIndex: cache.MetaNamespaceIndexFunc})
default:
return nil, fmt.Errorf("Unknown controller kind: %v", kind)
return nil, fmt.Errorf("unknown controller kind: %s", kind)
}
stopCh := make(chan struct{})
go informer.Run(stopCh)
synced := cache.WaitForCacheSync(stopCh, informer.HasSynced)
if !synced {
return nil, fmt.Errorf("Failed to sync %v cache.", kind)
return nil, fmt.Errorf("failed to sync %s cache", kind)
}
return informer, nil
}
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ func (lc *limitsChecker) GetPodLimitRangeItem(namespace string) (*core.LimitRang
func (lc *limitsChecker) getLimitRangeItem(namespace string, limitType core.LimitType) (*core.LimitRangeItem, error) {
limitRanges, err := lc.limitRangeLister.LimitRanges(namespace).List(labels.Everything())
if err != nil {
return nil, fmt.Errorf("error loading limit ranges: %s", err)
return nil, fmt.Errorf("Error loading limit ranges: %w", err)
}

updatedResult := func(result core.ResourceList, lrItem core.ResourceList,
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions vertical-pod-autoscaler/vendor/k8s.io/client-go/scale/client.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vertical-pod-autoscaler/vendor/k8s.io/utils/net/net.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

18 changes: 9 additions & 9 deletions vertical-pod-autoscaler/vendor/sigs.k8s.io/yaml/yaml.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 184fa9e

Please sign in to comment.